Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON for topics #24

Merged
merged 4 commits into from
Apr 14, 2012
Merged

JSON for topics #24

merged 4 commits into from
Apr 14, 2012

Conversation

emperorcezar
Copy link
Collaborator

Attempting to fix #23

So I noticed that you have models in there for topics and such. I've stuck some JSON in front of it. I just want an opinion on how I should handle starttime for a topic.

Options

  1. There is no order, so I can randomly assign an order and extrapolate a start time. This probably makes the start time useless to Carl.
  2. Add order field to topics. I don't see where to put a migration, so I'm assuming you're not using South? If I do this, do you want to have verification that the order is unique among topic in the same meeting. So, put in the code so that there aren't two topics with order of 1.

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

Questions for @CarlFK

@CarlFK
Copy link
Collaborator

CarlFK commented Apr 9, 2012

  1. Add start time and duration.
    This will help allocate times and stuff, like "This talk gets 30 min, this one 15."

(jhey github, that's a 3 up there, why you put a 1?)

@emperorcezar
Copy link
Collaborator Author

@CarlFK I don't think you understand. A meeting is attached to a topic, the meeting has a start time. The topics also have a duration. I need an order of the talks to figure out the start time of the talks.

Unless you mean I give topics start times also?

@CarlFK
Copy link
Collaborator

CarlFK commented Apr 9, 2012

Unless you mean I give topics start times also?

yes.

If you use duration, then every block of time has to be allocated, including the meeting start, breat, pizza, book give-away, etc. giving each a start time lets that be set to whatever, and some judgement as to what it should be.

Pluse it seems the easiest way, and I dount see how it would cause a problem. "meeting start" is pretty much a constant.

@emperorcezar
Copy link
Collaborator Author

Ok. That sounds reasonable. I'll go ahead and do that.

On Sun, Apr 8, 2012 at 11:20 PM, Carl Karsten <
[email protected]

wrote:

Unless you mean I give topics start times also?

yes.

If you use duration, then every block of time has to be allocated,
including the meeting start, breat, pizza, book give-away, etc. giving
each a start time lets that be set to whatever, and some judgement as to
what it should be.

Pluse it seems the easiest way, and I dount see how it would cause a
problem. "meeting start" is pretty much a constant.


Reply to this email directly or view it on GitHub:
#24 (comment)

@emperorcezar
Copy link
Collaborator Author

@brianray How do you want a migration handled on that? Are you just going to do it by hand?

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

I can not do a push to production between now and the meeting; however, your more than welcome. Also Daniel Peters showed some interests in helping this week.

@emperorcezar
Copy link
Collaborator Author

@brianray I mean the db migration. I didn't see south in the code base so I was wondering if you wanted me to write up the sql migration or if you were just going to go into your db and do it by hand?

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

I honestly do not recall if we have south here or not. My guess is your right, no south. I would be ok with a .sql file for migration, personally; however, please note that we use mysql in production, evident from the settings.py

@emperorcezar
Copy link
Collaborator Author

@brianray Double check my sql if you could?

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

what are you asking? please elaborate

@emperorcezar
Copy link
Collaborator Author

Just so someone will double check it. I don't have mysql on my macbook.

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

where is it?

@emperorcezar
Copy link
Collaborator Author

@brianray In the diff or in meetings/migrations/001.sql

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

I am really not a fan of keeping a start_time. I would prefer to tell someone how long they have and have a totally unstructured amount of time between presentations or just let a good one run longer. Must we have a start_time?

@emperorcezar
Copy link
Collaborator Author

I think the start time is more to help @CarlFK software and not something we have to enforce of speakers. I'm sure Carl could go into more detail. I believe that he records the whole thing and the starttime lets his software tell him where to look to split that video.

So. It's just a guess and it's not something we have to enforce of speakers.

@brianray
Copy link
Owner

brianray commented Apr 9, 2012

got it, ok. I will test this SQL and get back to you.

@dtpeters
Copy link
Collaborator

dtpeters commented Apr 9, 2012

@emperorcezar yeah, south isn't included yet, but it will be after I've upgraded to the latest release of pinax. do whatever you have to do and I'll follow behind man.

@emperorcezar
Copy link
Collaborator Author

@dtpeters For now just do the migration by hand instead of waiting for south. That way we can make Carl happy. We all love a happy Carl.

@dtpeters
Copy link
Collaborator

dtpeters commented Apr 9, 2012

@emperorcezar "we all love a happy carl" == truth

@emperorcezar
Copy link
Collaborator Author

Ok, just let me know when you're ready for merge.

brianray added a commit that referenced this pull request Apr 14, 2012
@brianray brianray merged commit 96817c6 into brianray:master Apr 14, 2012
@brianray
Copy link
Owner

OK, merged! I badly need someone to deploy this on chipy.org I'm simply too busy this week. Anyone?

@dtpeters
Copy link
Collaborator

I can get you. can it hold it until tomorrow night?

On Sat, Apr 14, 2012 at 8:12 AM, Brian Ray <
[email protected]

wrote:

OK, merged! I badly need someone to deploy this on chipy.org I'm simply
too busy this week. Anyone?


Reply to this email directly or view it on GitHub:
#24 (comment)

@CarlFK
Copy link
Collaborator

CarlFK commented Apr 14, 2012

sure - it can pretty much wait till someone puts in some data for next
months meeting.

On Sat, Apr 14, 2012 at 11:13 AM, Daniel Peters <
[email protected]

wrote:

I can get you. can it hold it until tomorrow night?

On Sat, Apr 14, 2012 at 8:12 AM, Brian Ray <
[email protected]

wrote:

OK, merged! I badly need someone to deploy this on chipy.org I'm simply
too busy this week. Anyone?


Reply to this email directly or view it on GitHub:
#24 (comment)


Reply to this email directly or view it on GitHub:
#24 (comment)

Carl K

@dtpeters
Copy link
Collaborator

sweet, it won't have to wait that long :P

On Sat, Apr 14, 2012 at 11:15 AM, Carl Karsten <
[email protected]

wrote:

sure - it can pretty much wait till someone puts in some data for next
months meeting.

On Sat, Apr 14, 2012 at 11:13 AM, Daniel Peters <
[email protected]

wrote:

I can get you. can it hold it until tomorrow night?

On Sat, Apr 14, 2012 at 8:12 AM, Brian Ray <
[email protected]

wrote:

OK, merged! I badly need someone to deploy this on chipy.org I'm
simply
too busy this week. Anyone?


Reply to this email directly or view it on GitHub:
#24 (comment)


Reply to this email directly or view it on GitHub:
#24 (comment)

Carl K


Reply to this email directly or view it on GitHub:
#24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

video metadata
4 participants